Write a test that shows that the query is valid #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
test-postgres-reader
branch
from
28b0b36
to
7a806a9
Compare
|
👍 I like it. Should we fail the build if the test takes over... 3 minutes? |
This also gives us a way to benchmark in order to see if we've adversely impacted the performance of the query.
jcoyne
force-pushed
the
test-postgres-reader
branch
from
7a806a9
to
b1e015a
Compare
|
@cbeer statement timeout has been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also gives us a way to benchmark in order to see if we've adversely impacted the performance of the query.