Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use filter_map when generating holdings #991

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Use filter_map when generating holdings #991

merged 1 commit into from
Jul 25, 2023

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Jul 18, 2023

Regression from #985 now that the map can break early.

@cbeer
Use filter_map when generating holdings
9702e17 
Regression from #985 now that the `map` can break early.
jcoyne
jcoyne reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a test?

@cbeer
Copy link
Member Author

cbeer commented Jul 19, 2023 •
edited
Loading

We don't have any unit tests for #sirsi_holdings, and presumably we won't have failed data when we actually migrate? 🤷‍♂️

@jcoyne jcoyne mentioned this pull request Jul 25, 2023
Closed
@jcoyne jcoyne merged commit 218b82f into main Jul 25, 2023
@jcoyne jcoyne deleted the cbeer-patch-2 branch July 25, 2023 15:54
@jcoyne
Copy link
Contributor

jcoyne commented Jul 25, 2023

Fixes #1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoyne jcoyne jcoyne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbeer @jcoyne