Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental ArticleRepository and ArticleController #583

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jun 22, 2021

Skeleton for Quick Testing this pull request: sulu/skeleton#236

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets parts of #690
License MIT

What's in this PR?

Add ArticleRepository and ArticleController getAction ContentBundle implementation.

Why?

We need a performant ArticleRepository for the ContentBundle integration and the Repository should be single interface to all which communicates with the database.

Related Pull Requests

Related Issues

TODO

  • Tests
  • Documentation for ArticleMapperInterface as official endpoint for create and modify handler

New Bundle Structure

  • Namespace: Sulu\Article under src
    • Application
      • Message
      • MessageHandler
    • Domain
      • Event (Domain Events, Activity)
        • ...
      • Models
        • Article
        • ArticleDimensionContent
      • Repository
        • ArticleRepositoryInterface
    • Infrastructure
      • Sulu
        • Admin
        • Content
          • Providers (Smart, Sitemap, Link, Teaser)
          • Content Types
        • Trash
          • 🤔
      • Doctrine
        • Repository
          • ArticleRepository
      • Symfony
        • HttpKernel
          • SuluArticleBundle
    • UserInterface
      • Controller
        • ArticleController

Open

But not part of this Pull Request:

  • Single Select Content Type
    • properties definitions
  • Multi Select Content TypeType
    • properties definitions
  • Smart Content TypeType
    • properties definitions
  • Teaser Provider
  • Link Provider
  • Sitemap Provider
  • Permissions
  • Handling Types
  • Activities
  • Trash
  • Reference

@alexander-schranz alexander-schranz force-pushed the feature/content-article-repository branch from b832467 to 889e235 Compare October 5, 2021 10:07
@alexander-schranz alexander-schranz marked this pull request as draft October 5, 2021 10:08
@alexander-schranz alexander-schranz changed the title WIP: Add ArticleRepository and ArticleController getAction ContentBundle implementation Add ArticleRepository and ArticleController getAction ContentBundle implementation Oct 5, 2021
@alexander-schranz alexander-schranz force-pushed the feature/content-article-repository branch from 889e235 to fbfc7f7 Compare October 5, 2021 11:07
@alexander-schranz alexander-schranz changed the title Add ArticleRepository and ArticleController getAction ContentBundle implementation Add experimental ArticleRepository and ArticleController Oct 12, 2021
@alexander-schranz alexander-schranz added DX Only affecting the end developer Feature New functionality not yet included labels Oct 15, 2021
@alexander-schranz alexander-schranz force-pushed the feature/content-article-repository branch 7 times, most recently from c021552 to 86fb215 Compare December 3, 2022 23:43
@alexander-schranz alexander-schranz force-pushed the feature/content-article-repository branch from 31e28a3 to f3a7309 Compare May 22, 2023 12:44
@alexander-schranz
Copy link
Member Author

@TheCadien finished with rebasing

@alexander-schranz alexander-schranz force-pushed the feature/content-article-repository branch from 2ad5c17 to fbead4b Compare August 8, 2024 09:04
@alexander-schranz alexander-schranz marked this pull request as ready for review August 8, 2024 09:21
@alexander-schranz alexander-schranz merged commit aa02c49 into sulu:3.0 Aug 8, 2024
0 of 7 checks passed
@alexander-schranz
Copy link
Member Author

To avoid that this PR get bigger I merged this now in 3.0 which where we can move forward then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Only affecting the end developer Feature New functionality not yet included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants