Add event-subscriber to throw flushed workflow events #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static function getSubscribedEvents() | ||
| { | ||
| return [ | ||
| sprintf('workflow.%s.completed', WorkflowInterface::WORKFLOW_DEFAULT_NAME) => 'onCompleted', |
There was a problem hiding this comment.
create an issue that this is here hardcoded and we should find a way that this events are also thrown for custom workflows
There was a problem hiding this comment.
we could hear on workflow.completed and check for the names (but they have to be declared then somehow)
There was a problem hiding this comment.
do we know all the names of the worklows?
wachterjohannes
force-pushed
the
feature/flushed-events
branch
2 times, most recently
from
94bc27b
to
5323396
Compare
wachterjohannes
force-pushed
the
feature/flushed-events
branch
from
5323396
to
a6c4698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129