Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Symfony 7 support #92

Merged
merged 18 commits into from
Jul 24, 2024
Merged

Add Symfony 7 support #92

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f8dde39
Add Symfony 7 Support
TheCadien Jul 18, 2024
54b9fd4
Remove Subscriber interface
TheCadien Jul 18, 2024
4a6e1d1
Remove interface
TheCadien Jul 18, 2024
4b5766f
set LifecycleEventArgs
TheCadien Jul 18, 2024
2dfeab2
Remove emtpy line
TheCadien Jul 18, 2024
28c217a
Remove php-cs-fixer.cache
TheCadien Jul 19, 2024
cb3d56c
Fix Typo in Composer.json
TheCadien Jul 19, 2024
05fb2f3
Update Command
TheCadien Jul 19, 2024
d661dad
Update Unittest
TheCadien Jul 19, 2024
2913a73
Remove mocking from input Bag
TheCadien Jul 19, 2024
5d783fc
Set Different bags for test
TheCadien Jul 23, 2024
fbb26b3
Change @var parameter
TheCadien Jul 23, 2024
12e05b5
Remove Baseline row
TheCadien Jul 23, 2024
b537a50
baseline
TheCadien Jul 23, 2024
47760b2
test
TheCadien Jul 23, 2024
7ebe48f
set preremove event
TheCadien Jul 23, 2024
4c71b37
Refactor Request Mock
TheCadien Jul 23, 2024
77d0ac5
Refactor Tests
TheCadien Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions Tests/Unit/Controller/RedirectControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ class RedirectControllerTest extends TestCase
*/
private $controller;

/**
* @var Request
*/
private $request;

/**
* @var InputBag|ParameterBag
*/
Expand All @@ -45,22 +40,22 @@ protected function setUp(): void
{
$this->controller = new WebsiteRedirectController();

$this->request = $this->prophesize(Request::class);
$this->queryBag = class_exists(InputBag::class) ? new InputBag() : new ParameterBag();
$this->redirectRoute = $this->prophesize(RedirectRouteInterface::class);

$this->request->reveal()->query = $this->queryBag;
}

public function testRedirect()
{
$target = '/test';
$statusCode = 301;

$request = Request::create($target);
$request->query = $this->queryBag;
TheCadien marked this conversation as resolved.
Show resolved Hide resolved

$this->redirectRoute->getTarget()->willReturn($target);
$this->redirectRoute->getStatusCode()->willReturn($statusCode);

$response = $this->controller->redirect($this->request->reveal(), $this->redirectRoute->reveal());
$response = $this->controller->redirect($request, $this->redirectRoute->reveal());

$this->assertInstanceOf(RedirectResponse::class, $response);
$this->assertEquals($target, $response->getTargetUrl());
Expand All @@ -75,10 +70,13 @@ public function testRedirectWithQuery()

$this->queryBag->add($query);

$request = Request::create($target);
$request->query = $this->queryBag;

$this->redirectRoute->getTarget()->willReturn($target);
$this->redirectRoute->getStatusCode()->willReturn($statusCode);

$response = $this->controller->redirect($this->request->reveal(), $this->redirectRoute->reveal());
$response = $this->controller->redirect($request, $this->redirectRoute->reveal());

$this->assertInstanceOf(RedirectResponse::class, $response);
$this->assertEquals(
Expand All @@ -93,10 +91,13 @@ public function testRedirectExternal()
$target = 'http://captain-sulu.io/test';
$statusCode = 301;

$request = Request::create($target);
$request->query = $this->queryBag;

$this->redirectRoute->getTarget()->willReturn($target);
$this->redirectRoute->getStatusCode()->willReturn($statusCode);

$response = $this->controller->redirect($this->request->reveal(), $this->redirectRoute->reveal());
$response = $this->controller->redirect($request, $this->redirectRoute->reveal());

$this->assertInstanceOf(RedirectResponse::class, $response);
$this->assertEquals(
Expand All @@ -114,10 +115,13 @@ public function testRedirectExternalWithQuery()

$this->queryBag->add($query);

$request = Request::create($target);
$request->query = $this->queryBag;

$this->redirectRoute->getTarget()->willReturn($target);
$this->redirectRoute->getStatusCode()->willReturn($statusCode);

$response = $this->controller->redirect($this->request->reveal(), $this->redirectRoute->reveal());
$response = $this->controller->redirect($request, $this->redirectRoute->reveal());

$this->assertInstanceOf(RedirectResponse::class, $response);
$this->assertEquals(
Expand Down
13 changes: 1 addition & 12 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,12 +320,6 @@ parameters:
count: 4
path: Tests/Unit/Controller/RedirectControllerTest.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\HttpFoundation\\\\Request\\:\\:reveal\\(\\)\\.$#"
count: 4
path: Tests/Unit/Controller/RedirectControllerTest.php


-
message: "#^Cannot call method willReturn\\(\\) on int\\.$#"
count: 4
Expand Down Expand Up @@ -361,14 +355,9 @@ parameters:
count: 1
path: Tests/Unit/Controller/RedirectControllerTest.php

-
message: "#^Property Sulu\\\\Bundle\\\\RedirectBundle\\\\Tests\\\\Unit\\\\Controller\\\\RedirectControllerTest\\:\\:\\$request \\(Symfony\\\\Component\\\\HttpFoundation\\\\Request\\) does not accept Prophecy\\\\Prophecy\\\\ObjectProphecy\\<Symfony\\\\Component\\\\HttpFoundation\\\\Request\\>\\.$#"
count: 1
path: Tests/Unit/Controller/RedirectControllerTest.php

-
message: "#^Property Symfony\\\\Component\\\\HttpFoundation\\\\Request\\:\\:\\$query \\(Symfony\\\\Component\\\\HttpFoundation\\\\InputBag\\<string\\>\\) does not accept Symfony\\\\Component\\\\HttpFoundation\\\\ParameterBag\\.$#"
count: 1
count: 4
path: Tests/Unit/Controller/RedirectControllerTest.php

-
Expand Down
Loading