Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FosHttpCache 3.0 and FosHttpCacheBundle 3.0 #249

Merged

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jun 10, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs sulu/sulu#7452
License MIT
Documentation PR sulu/sulu-docs#prnum

What's in this PR?

Add support for FosHttpCache 3.0 and FosHttpCacheBundle 3.0.

Why?

Make sure to install the correct versions of http cache but also the other bundles

"doctrine/doctrine-bundle": "^2.5",
"doctrine/doctrine-fixtures-bundle": "^3.4",
"friendsofsymfony/http-cache-bundle": "^2.17",
"doctrine/doctrine-bundle": "^2.12",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we install the 2.12 recipe so we need also require it else oro extension can accidently downgrad it which is unexpected.

@alexander-schranz alexander-schranz added the enhancement New feature or request label Jun 10, 2024
@alexander-schranz alexander-schranz force-pushed the enhancement/support-fos-http-cache-3-0 branch from a6dcd3f to b3fa7d4 Compare June 27, 2024 11:39
@alexander-schranz alexander-schranz marked this pull request as ready for review June 27, 2024 12:03
@Prokyonn Prokyonn merged commit 724aa9e into sulu:2.6 Jun 27, 2024
4 checks passed
@alexander-schranz alexander-schranz deleted the enhancement/support-fos-http-cache-3-0 branch June 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants