Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English Support #376

Closed
8 of 10 tasks
sunfish-shogi opened this issue Feb 6, 2023 · 6 comments
Closed
8 of 10 tasks

English Support #376

sunfish-shogi opened this issue Feb 6, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sunfish-shogi
Copy link
Owner

sunfish-shogi commented Feb 6, 2023

https://github.com/sunfish-shogi/electron-shogi/issues/18

TODO

  • UI Components
  • Menu Bar Items
  • Dialog Messages
  • Error Messages
  • Moves
  • Record Metadatas
  • Web Pages
  • README
  • How to Use
  • Contact Form
@sunfish-shogi sunfish-shogi added the enhancement New feature or request label Feb 6, 2023
@sunfish-shogi sunfish-shogi added this to the v1.6.0 milestone Feb 6, 2023
@sunfish-shogi sunfish-shogi self-assigned this Feb 6, 2023
@bodhi-baum
Copy link

I would like to help with the translation.

@sunfish-shogi
Copy link
Owner Author

@bodhi-baum
Thank you for your interest in this project.

I have translated most of words/sentences.
But it probably has some unnatural expressions or mistakes.
I would be helpful if you could correct those translation.
You can see all words at https://github.com/sunfish-shogi/electron-shogi/blob/main/src/common/i18n/translate.ts
(v1.6.0-alpha.1 includes only part of it. I'm considering to release v1.6.0-alpha.2 with latest changes.)

And I have not traslated following Shogi phrases so far.

  • 緩手
  • 疑問手
  • 悪手
  • 大悪手
  • 秒読み

Because, I could not find English translation of each phrases.
Do you know words which chess players use above meanings, or any helpful references?

@sunfish-shogi
Copy link
Owner Author

@Quisette
Copy link
Contributor

Quisette commented Apr 9, 2023

Hello @sunfish-shogi,

Regarding the Shogi phrases mentioned above, I've found some links below:

Therefore, these Shogi terms may be translated as follows:

  • 緩手: inaccuracy
  • 疑問手: dubious
  • 悪手: mistake
  • 大悪手 : blunder
  • 秒読み: maybe just byoyomi? I've seen most of international Shogi sites have used this translation.

By the way, is any pull request about translation editing allowed?
If OK, I'll update the translation using these terms and help refine other translations using PR.

Hope this helps! Thanks!

@sunfish-shogi sunfish-shogi mentioned this issue Apr 9, 2023
@sunfish-shogi
Copy link
Owner Author

sunfish-shogi commented Apr 9, 2023

@Quisette

Thank you!!

緩手: inaccuracy
疑問手: dubious
悪手: mistake
大悪手 : blunder
秒読み: maybe just byoyomi? I've seen most of international Shogi sites have used this translation.

I just added these terms at following PR.

https://github.com/sunfish-shogi/electron-shogi/pull/453

By the way, is any pull request about translation editing allowed?
If OK, I'll update the translation using these terms and help refine other translations using PR.

Of cource, I welcome any PR to refine translations!

@sunfish-shogi
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants