Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Language Support #481

Open
14 of 20 tasks
Quisette opened this issue Apr 27, 2023 · 6 comments
Open
14 of 20 tasks

Multiple Language Support #481

Quisette opened this issue Apr 27, 2023 · 6 comments

Comments

@Quisette
Copy link
Contributor

Quisette commented Apr 27, 2023

This issue is presented to add other language supports into this repository.
By the way, I have included and kept issue #376 update in this issue as well.

Languages

  • English
    • UI Components
    • Menu Bars
    • Dialogs
    • Errors
    • Moves (RecordView)
    • Record Metadata
    • Webpages
    • README
    • Usage / Tutorial
    • Contact Form
  • Traditional Chinese
    • UI Components
    • Menu Bars
    • Dialogs
    • Errors
    • Record Metadata
    • USI Translation
    • Webpages
    • README
    • Usage / Tutorial
    • Contact Form
@Quisette
Copy link
Contributor Author

Since Traditional Chinese is my native language, I'll try translating this repository to Traditional Chinese First.

@sunfish-shogi
Copy link
Owner

sunfish-shogi commented Apr 28, 2023

Thank you for your PR (#483) .
This update will be included in v1.7.0 and I hope it will increase users and contributers.

By the way, I'm wondering which way I do when adding new words/sentences.

  1. write Traditional Chinese using machine translation
  2. write Japanese and TODO comment
  3. write English and TODO comment

@Quisette
Copy link
Contributor Author

Since I can understand Japanese, I think it is OK to add the lines and left the Japanese untranslated.
For other languages, since we need some precise translation, leaving Japanese is good for now. ( They can reference to English terms manually)

BTW, I don't recommend direct machine translation since the translated terms are not usually decent to native language and sometimes make users/devs misunderstand some meanings.

@Quisette
Copy link
Contributor Author

Also, since the translate.ts will become larger by more languages implemented in the future, I think if it is possible to separate each language to their specific .ts file.

If OK, I'll make a issue later and try to modify the directory in the next pull request.

@sunfish-shogi
Copy link
Owner

@Quisette

Since I can understand Japanese, I think it is OK to add the lines and left the Japanese untranslated.
For other languages, since we need some precise translation, leaving Japanese is good for now. ( They can reference to English terms manually)
BTW, I don't recommend direct machine translation since the translated terms are not usually decent to native language and sometimes make users/devs misunderstand some meanings.

Thank you for your advice.
I will write Japanese and TODO comment.

Also, since the translate.ts will become larger by more languages implemented in the future, I think if it is possible to separate each language to their specific .ts file.
If OK, I'll make a issue later and try to modify the directory in the next pull request.

Sounds good. I agree your suggestion.

@sunfish-shogi
Copy link
Owner

sunfish-shogi commented Aug 9, 2023

Moves (need to use other kifu format)

Moves of original issue indicates moves in RecordView, not kifu file formats.

"How to Read Shogi Notation? The explanation of Kifu"
https://www.youtube.com/watch?v=tG-Sbo6FJ9Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants