8.0 l10n xaf export changes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaspaulb
requested changes
Dec 19, 2017
.travis.yml
Outdated
| - VERSION="8.0" LINT_CHECK="1" | ||
| - VERSION="8.0" ODOO_REPO="odoo/odoo" LINT_CHECK="0" | ||
| - VERSION="8.0" ODOO_REPO="OCA/OCB" LINT_CHECK="0" | ||
| global: |
There was a problem hiding this comment.
@Hayyan-Ebrahem Analysing this will go as follows:
- Look at the most recent version of this file on the 8.0 branch in the original OCA repo, and activate the Blame view.
- See that this change was added 9 months ago by Holger in this commit
- Conclude that this should not be in this PR.
- Look at the commits in this PR and conclude that they are too many - it should include only your commit.
- Follow this guide to get out of trouble.
| @@ -653,7 +653,6 @@ | |||
| <xsd:enumeration value="AT"/> | |||
| <xsd:enumeration value="AU"/> | |||
| <xsd:enumeration value="AW"/> | |||
| <xsd:enumeration value="AX"/> | |||
There was a problem hiding this comment.
@Hayyan-Ebrahem As another example I will analyse this:
- Look at the most recent version of this file on the 8.0 branch in the original OCA repo, and activate the Blame view.
- See that
AXwas added 4 months ago by Andrea in this commit - Conclude that reverting this should not be in this PR - it is not our work, but the reversion of a later update by someone from OCA.
- Remove it from your branch in a new commit
| }) | ||
| xml = self.env.ref('l10n_nl_xaf_auditfile_export.auditfile_template')\ | ||
| .render(values={ | ||
| 'self': self.sudo(), |
There was a problem hiding this comment.
@Hayyan-Ebrahem as a final example, lets analyse this one:
- Look at the most recent version of this file on the 8.0 branch in the original OCA repo, and activate the Blame view.
- See that the newest OCA version is not including this at the moment
- In the Blame view of that file in the Freshfilter community modules repo, see that it was added by us in this commit
- Decide to keep it
Hayyan-Ebrahem
force-pushed
the
8.0-l10n-xaf-export-changes
branch
from
bbfa743
to
ae4c508
Compare
thomaspaulb
pushed a commit
that referenced
this pull request
Sep 7, 2018
….0/performance_patch1 [IMP] Compute auditfile_name field
thomaspaulb
pushed a commit
that referenced
this pull request
Nov 17, 2020
[13.0] Rename l10n_nl_ubl to l10n_nl_base_ubl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.