🤏 Better silence management/encoding #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so output wav can be easily previewed on various platforms and easily compressed to mp3/webm suno-ai#288
adriens
changed the title
|
not sure i understand the title of this PR.. |
|
In fact, this PR is to make a better slience management so output wav can be easily compressed to |
|
I think I can translate. He's probably getting 32 or 64 bit wav files however he's running or integrating that code, because it's matching the type from np.zeros silence segments. The files are bigger and some players don't like them, windows media player won't play the 32 bit ones. Kind of a implementation detail though, not really a problem. |
|
This PR should be good to land IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so output wav can be easily previewed on various platforms and easily compressed to mp3/webm :