-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TableCoordinates support pixel edges and centers #713
base: main
Are you sure you want to change the base?
Conversation
… corners and centers.
…flect centers and corners grid structure.
@Cadair Can you advise on whether this is the best way to go about this? |
Make |
Hello 👋, Thanks for your contribution to ndcube! |
Hello again 👋, We want to thank you again for your contribution to ndcube! |
PR Description
This PR enables support for custom pixel edges in
QuantityTableCoordinate
andTimeTableCoordinate
objects by storing the underlying grids as including pixel edges and centers, not just centers as heretonow.The motivation is that world coordinates at pixel edges are often wanted. When the pixel widths are uniform, the edges can be found from the centers. However, when this is not the case, explicit knowledge of the edges is required.