Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an example for advanced usage of WOW #238

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Added an example for advanced usage of WOW #238

merged 4 commits into from
Oct 29, 2024

Conversation

frederic-auchere
Copy link
Contributor

This a an example of some more advanced usage of the WOW algorithm. It demonstrates regular vs. edge-aware flavors, denoising, and merging with the input data.

nabobalis
nabobalis approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@nabobalis nabobalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really minor suggestions.

examples/advanced_wow.py Outdated Show resolved Hide resolved
examples/advanced_wow.py Outdated Show resolved Hide resolved
examples/advanced_wow.py Outdated Show resolved Hide resolved
examples/advanced_wow.py Outdated Show resolved Hide resolved
examples/advanced_wow.py Outdated Show resolved Hide resolved
examples/advanced_wow.py Outdated Show resolved Hide resolved
examples/advanced_wow.py Outdated Show resolved Hide resolved
examples/advanced_wow.py Outdated Show resolved Hide resolved
examples/advanced_wow.py Outdated Show resolved Hide resolved
examples/advanced_wow.py Outdated Show resolved Hide resolved
@nabobalis
Copy link
Contributor

A short changelog as well and I think this is good to go.
Thanks for working on this @frederic-auchere

@frederic-auchere
Copy link
Contributor Author

frederic-auchere commented Oct 25, 2024 •
edited
Loading

Thanks Nabil !

Don't know anything about changelogs (but willing to learn !) Is there anything I should do ?

@nabobalis
Copy link
Contributor

Don't know anything about changelogs (but willing to learn !) Is there anything I should do ?

Sorry, I didn't see this edit. I pushed the changelog, so you can see how the system works.

@nabobalis
Copy link
Contributor

The rendered version is here: https://sunpy--238.org.readthedocs.build/projects/sunkit-image/en/238/generated/gallery/advanced_wow.html#sphx-glr-generated-gallery-advanced-wow-py

See if you like it @frederic-auchere and if so I think this is good to merge.

@frederic-auchere
Copy link
Contributor Author

See if you like it @frederic-auchere and if so I think this is good to merge.

I do !

@nabobalis nabobalis merged commit f0ab3a5 into sunpy:main Oct 29, 2024
23 checks passed
@nabobalis
Copy link
Contributor

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederic-auchere @nabobalis