Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Specific permission for resend_activation #857

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

73VW
Copy link

@73VW 73VW commented Dec 11, 2024

This PR adds a specific permission for resend_activation action based on the discussion here: #761

What has been done:

  • Add specific permission;
  • Rename SendEmailResetSerializer to SendEmailSerializer and use it for resend_activation (consistency fix)
  • Add test with different permission for resend_activation
  • Update documentation

@73VW 73VW marked this pull request as draft December 11, 2024 09:08
@73VW 73VW force-pushed the add-permission-for-resend_activation branch 2 times, most recently from dc135ab to a125ecd Compare December 11, 2024 09:21
@73VW 73VW marked this pull request as ready for review December 11, 2024 09:23
@73VW 73VW force-pushed the add-permission-for-resend_activation branch from a125ecd to 777f296 Compare December 11, 2024 09:24
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (9deaa63) to head (777f296).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          27       27           
  Lines         903      903           
=======================================
  Hits          891      891           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant