Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WASM-JS and migrate to Ktor 3.0.0 #311

Merged
merged 58 commits into from
Sep 12, 2024
Merged

Add support for WASM-JS and migrate to Ktor 3.0.0 #311

merged 58 commits into from
Sep 12, 2024

Conversation

jan-tennert
Copy link
Collaborator

@jan-tennert jan-tennert commented Oct 13, 2023

What kind of change does this PR introduce?

Feature (closes #86)

What is the current behavior?

N/A

What is the new behavior?

New wasm-js target for supabase-kt

Supported modules:

  • supabase-kt
  • gotrue-kt
  • storage-kt
  • functions-kt
  • postgrest-kt
  • realtime-kt
  • compose-auth
  • compose-auth-ui
  • apollo-graphql
  • coil3-integration

Note: I'll probably add wasm-js to supported samples once this is merged.

Additional context

The implementation should be almost the same as the js browser implementation. wasm-wasi support may also come if the libraries support it.
The Github documentation has been changed accordingly.

@jan-tennert jan-tennert added the enhancement New feature or request label Oct 13, 2023
@jan-tennert jan-tennert added this to the 1.5.0 milestone Oct 13, 2023
@jan-tennert jan-tennert self-assigned this Oct 13, 2023
@jan-tennert jan-tennert added the freezer On hold label Oct 21, 2023
@jan-tennert
Copy link
Collaborator Author

jan-tennert commented Oct 21, 2023

Putting this on hold until official KotlinX versions release.

@jan-tennert
Copy link
Collaborator Author

jan-tennert commented Nov 15, 2023

KotlinX Serialization, Coroutines and atomicfu now have official support, ktor and coroutines to go 👍

@jan-tennert jan-tennert reopened this Dec 1, 2023
@jan-tennert jan-tennert changed the title Add support for WASM Add support for WASM-JS Dec 1, 2023
@jan-tennert jan-tennert modified the milestones: 2.0.0, 2.1.0 Dec 4, 2023
@mikepenz
Copy link

@jan-tennert
Copy link
Collaborator Author

ktor has an experimental wasm2 build available here: https://youtrack.jetbrains.com/issue/KTOR-5587/Ktor-client-for-Kotlin-Wasm#focus=Comments-27-8670434.0-0

I know, the only problem is that these builds do not support some Kotlin targets required for this project. I might publish separate wasm builds until the official release.

@jan-tennert jan-tennert changed the base branch from development to master December 27, 2023 11:41
@jan-tennert
Copy link
Collaborator Author

ktor has an experimental wasm2 build available here: https://youtrack.jetbrains.com/issue/KTOR-5587/Ktor-client-for-Kotlin-Wasm#focus=Comments-27-8670434.0-0

I know, the only problem is that these builds do not support some Kotlin targets required for this project. I might publish separate wasm builds until the official release.

Update: Published a compatible build 2.0.2-wasm0

@mikepenz
Copy link

Thank you very much!

# Conflicts:
#	gradle.properties
# Conflicts:
#	GoTrue/src/jsMain/kotlin/io/github/jan/supabase/gotrue/setupPlatform.kt
#	gradle.properties
# Conflicts:
#	gradle.properties
# Conflicts:
#	gradle.properties
#	gradle/libs.versions.toml
@github-actions github-actions bot removed the core label Aug 17, 2024
@jan-tennert jan-tennert removed freezer On hold blocked by dependency This feature cannot be implemented as one ore more dependencies need an update. labels Sep 6, 2024
# Conflicts:
#	GoTrue/src/settingsMain/kotlin/io/github/jan/supabase/gotrue/SettingsCodeVerifierCache.kt
#	GoTrue/src/settingsMain/kotlin/io/github/jan/supabase/gotrue/SettingsSessionManager.kt
#	Storage/src/settingsMain/kotlin/io/github/jan/supabase/storage/resumable/SettingsResumableCache.kt
#	gradle/libs.versions.toml
@jan-tennert jan-tennert marked this pull request as ready for review September 10, 2024 15:38
@jan-tennert
Copy link
Collaborator Author

I'll definitely squash that PR.

@jan-tennert jan-tennert merged commit d579783 into master Sep 12, 2024
13 checks passed
@jan-tennert jan-tennert deleted the wasm branch September 12, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Add support for WASM
2 participants