Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid empty file created on Dashboard by early checking for empty data #577

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Avoid empty file created on Dashboard by early checking for empty data #577

merged 5 commits into from
Apr 30, 2024

Conversation

hieuwu
Copy link
Contributor

@hieuwu hieuwu commented Apr 30, 2024 •
edited
Loading

What kind of change does this PR introduce?

This is to fix #576

What is the current behavior?

Silently create an empty file as detailed in the issue

What is the new behavior?

Throw IllegalArgumentException when pass empty data to any upload function requiring data with ByteArray type

Screenshot 2024-04-30 at 20 37 32

@hieuwu hieuwu requested a review from jan-tennert as a code owner April 30, 2024 13:57
jan-tennert
jan-tennert approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@jan-tennert jan-tennert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jan-tennert jan-tennert merged commit 557b7a4 into supabase-community:master Apr 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-tennert jan-tennert jan-tennert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: [Storage] Empty file is created on Dashboard when pass empty ByteArray to upload function
2 participants
@hieuwu @jan-tennert