Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chat demo to root project & improve chat demo #636

Merged
merged 8 commits into from
Jul 1, 2024

Conversation

jan-tennert
Copy link
Collaborator

What kind of change does this PR introduce?

Samples

What is the current behavior?

The chat demo has their own Gradle instance and is not part of the project.

What is the new behavior?

The chat demo is now part of the root project and can be used to try out changes easily

Additional context

See #573

@jan-tennert jan-tennert added the enhancement New feature or request label Jun 30, 2024
@jan-tennert jan-tennert self-assigned this Jun 30, 2024
@jan-tennert
Copy link
Collaborator Author

@MohamedRejeb thoughts?

Copy link
Contributor

@MohamedRejeb MohamedRejeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
For Kotlin GP and AGP, they can be applied with alias the same way as other plugins:
alias(libs.plugins.kotlin.multiplatform)

sample/chat-demo-mpp/desktop/build.gradle.kts Show resolved Hide resolved
@jan-tennert jan-tennert marked this pull request as ready for review June 30, 2024 14:39
Copy link
Contributor

@MohamedRejeb MohamedRejeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jan-tennert jan-tennert merged commit 2c3f973 into master Jul 1, 2024
9 checks passed
@jan-tennert jan-tennert deleted the move-chat-demo branch August 1, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants