Add Realtime tests by abstracting realtime websockets #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Realtime/src/commonMain/kotlin/io/github/jan/supabase/realtime/RealtimeImpl.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Tests
What is the current behavior?
There are no realtime tests.
What is the new behavior?
I followed up on #658; creating realtime websocket tests, but instead of using ktor's
server-host, I separated Ktor's websockets from realtime-kt. This is done by adding a new config propertyRealtimeWebsocketFactorywhich creates aRealtimeWebsocket, so you can provide your ownRealtimeWebsocketFactory. By default, this is aKtorRealtimeWebsocketFactory. For the tests aChannelis used for communication.This PR also adds support for broadcasting to private channels via the API.
Additional context
Add any other context or screenshots.