Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action for chart release #55

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

drpsyko101
Copy link
Contributor

What kind of change does this PR introduce?

This PR brings automatic chart release for every successful PR into the main branch. No more fiddling around with build script and manually changing index.yaml. Other changes include:

  • Add previous 0.1.0 build data
  • Limit linting and chart test to specific file changes
  • Remove chart build script

Pre-requisites

  • Secret GITHUB_TOKEN permission for contents should (?) be set to read/write.

Known issues

  • The new GitHub action is only tested in a very limited configuration, and may cause error in an untested environment.

* add previously missing build
* set lint test to only main branches
* set actions to only affect chart modification
* enable lint test job interrupt
- "**.yaml"
- "**.yml"
- "**.tpl"
# Exclude build index.yaml from being collected into action
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exclusion looks redundant, since GITHUB_TOKEN does not recursively call the same action. More information needed.

@arpagon arpagon self-requested a review April 15, 2024 15:48
@arpagon
Copy link
Member

arpagon commented Apr 15, 2024

👋 Hi @drpsyko101,

I have a few points to discuss regarding the publication of the chart and the chart repo:

  1. Currently, I don't have the permissions to modify the GITHUB_TOKEN settings. We might need kiwicopple adjust the token's permissions to enable read/write operations as required by the helm/chart-releaser-action.
  2. I've been considering the idea of using OCI registries for storing our Helm charts. It seems like a solid approach to align our chart management with the way we handle container images. What are your thoughts on this?
  3. The Helm OCI Chart Releaser GitHub Action and the Helm documentation on registries caught my attention as potentially useful tools for our project. It might be worth exploring this further.

Looking forward to your thoughts.

@drpsyko101
Copy link
Contributor Author

@arpagon Thanks for the approval!

Helm OCI is indeed the best way to release this chart alongside the official Supabase images. But I don't think we should at this point, not until this chart is considered production-ready.

Need more input from @kiwicopple on this topic and the roadmap #53 , especially for the definition of production-ready in Supabase context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants