Add tests to ensure that pastes are reaped properly. #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtlrs
force-pushed
the
reap-tasks-properly
branch
from
ee0f3e7
to
1a1ea98
Compare
|
Strange, the e2es ran fine locally. I'll investigate this tomorrow. |
|
The tests are failing because there's a bug when it comes to loading the config file. Expiries and ratelimites are not being overwritten. I'll have a look and fix that. |
1. This adds no maintenance cost 2. This is a nice to have feature if anyone wanted to configure it 3. This will allow us to test the task easily.
shtlrs
force-pushed
the
reap-tasks-properly
branch
from
1a1ea98
to
8160a9f
Compare
|
Strange, but 1de2f0b from #231 isn't present in my local repo. @supakeen Where do we use this EDITI've fixed it by not downgrading gitpython when installing pytest-asyncio. |
This will allow us to execute async tests. The reason it's needed is we want to be able to call asyncio.sleep so that we don't block the event loop while waiting for other tasks to be ran
This is part of a restructure of how database connections/engines/ are created
This ensure that we don't have global resource variables available all across modules. The delegation will help contain the instance better, and operate more granulay on it during tests.
This makes the localization more precise
The Configuration class will help structure the configuration better and will allow us to mock values easier when testing. The ConfigurationProvider is responsible for providing the same config across the entire app through late binding.
shtlrs
force-pushed
the
reap-tasks-properly
branch
from
8160a9f
to
54f391d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182
Structural changes
Some refactoring has been done in order to make testing easier, but also to improve the overall quality.
Database models
All db models have been moved to their own
modelsmodule.DatabaseManager
The
engineinstance was a global variable that everyone could access/see from thedatabasemodule. This isn't quite a good approach as it's always better to have aproviderfor such things.Enter the
DatabaseManager: A class to handle database-related resources better, in this case: the engine and a sessionThis helps us
hidethe engine from its peers by making it available only through a provider method.It also helps us alot when it comes to testing, since we can monkey patch the instance per scope easier.
Configuration & ConfigurationProvider
We used to have problems when it comes to getting the same configuration, imports were placed inside functions to ensure that values are bound to variables correctly.
This has been handled thanks to the
ConfigurationProviderand theConfigurationclasses.ConfigurationThis is just a class whose responsibilits is to encapsulate the configuration values we have, to make sure these values are not affected by imports thanks to late binding.
This will also make monkeypatching/mocking easier.
ConfigurationProviderThis acts as the unique source of truth of the
Configurationinstance by making it a Singleton, thus making it the one responsible for instantiating the configuration when needed.Features
This PR adds support for making the reaping task's periodicity configurable.
Tests
It also adds tests that do the following
reaptask keeps running when the app has started.