Couple of fixes for MP3 quark subprocesses #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added another commit to post a warning if the subprocess crashes. In the current development branch, SC does not post I know it's not directly related to the first commit, but I'm busy, and it's really complicated to separate these. I don't have time to do anything more than this. |
jamshark70
changed the title
m = MP3(...); m.start; m.stop; m.stop; Second stop posts "MP3.stop - unable to stop automatically, PID not known" -- but it was already stopped! Should check playing status before this.
|
please commit |
dyfer
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Sorry this was never attended to.
@jamshark70 if this is still valid, feel free to merge.
|
Also note, SC 3.13 includes native support for mp3. This works out of the box on macOS and Windows, but on Linux SC needs to be compiled against libsndfile >= 1.1.0 which itself was compiled with mpeg support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pidRunninghas existed for 10 years.isPIDRunningis gone -- "not understood."Tested, works.