Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDESK-7386] Add Resource Data & Web signals #2817

Open
wants to merge 11 commits into
base: async
Choose a base branch
from
Open

[SDESK-7386] Add Resource Data & Web signals #2817

wants to merge 11 commits into from

Conversation

MarkLark86
Copy link
Contributor

@MarkLark86 MarkLark86 commented Jan 15, 2025 •
edited by jira bot
Loading

Purpose

To enhance the current signal system and make use of it in Resources.

What has changed:

  • Added Signal and SignalGroup classes
  • Add a on_resource_registered signal to the resources system
  • Add web and data signals to async resources
  • Improve code layout (specifically for resources and mongo modules) - these files were getting big, so I decided to split them up

Resolves: SDESK-7386

@MarkLark86 MarkLark86 added this to the 3.0 milestone Jan 15, 2025
@MarkLark86
Copy link
Contributor Author

Docs for this PR can be found here

@MarkLark86 MarkLark86 requested review from eos87 and petrjasek January 15, 2025 06:40
eos87
eos87 approved these changes Jan 18, 2025
View reviewed changes
Copy link

@eos87 eos87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach :) Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eos87 eos87 eos87 approved these changes

@petrjasek petrjasek Awaiting requested review from petrjasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkLark86 @eos87