[SDESK-7443] - Planning: Migrate planning:delete_spiked command to async #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDESK-7441
BrianMwangi21
force-pushed
the
SDESK-7443
branch
from
0a2beeb to
f9763d8
Compare
Fix behave tests partially SDESK-7441 Allow behave tests to run async code SDESK-7441 Fix pytests and use python 3.10 only Disable some actions and add verbose mode 999 Remove python 3.8 Point sd core to fix branch Revert "Fix linter issues" This reverts commit 152cfb5. Revert changes to ci-install SDESK-7441 Fix first batch of tests Reapply "Fix linter issues" This reverts commit e5ac69a. Fix second batch of tests SDESK-7441 Fix tests batch 3 Fix tests batch 4 SDESK-7441 Fix superdesk-core dependency Fix linter issues SDESK-7441
SDESK-7441
MarkLark86
reviewed
Nov 28, 2024
BrianMwangi21
force-pushed
the
SDESK-7443
branch
from
2c2efae to
114a507
Compare
BrianMwangi21
force-pushed
the
SDESK-7443
branch
2 times, most recently
from
153f58f to
7d1f4e6
Compare
BrianMwangi21
force-pushed
the
SDESK-7443
branch
from
7d1f4e6 to
882f818
Compare
SDESK-7441
SDESK-7441
SDESK-7441
SDESK-7441
SDESK-7441
|
@BrianMwangi21 There seems to be a couple unit tests failing. One with the elasticsearch query for the delete command, and another in the test using dictionary access instead of ResourceModel access. i.e. assignments[plan_id] = planning["coverages"][0]["assigned_to"]["assignment_id"]
TypeError: 'PlanningResourceModel' object is not subscriptable |
|
Yeah, I'm working on those. |
BrianMwangi21
force-pushed
the
SDESK-7443
branch
from
4fe3a41 to
dff41e8
Compare
MarkLark86
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the
planning:delete_spikedcommand to async by:Solves SDESK-7443
Note
This PR depends on #2131 so it is quite big but will become concise when the PR is merged.