Handle failed changes properly #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromegn
reviewed
Nov 28, 2024
| pub fn process_complete_version( | ||
| agent: Agent, | ||
| tx: &Transaction, | ||
| sp: &Savepoint, |
There was a problem hiding this comment.
Little bit of fun knowledge: Both Transaction and Savepoint implement Deref<Target=Connection>, so we could use &Connection here as a type and it'd "just work" properly, but it is nicer to have it explicit like you did there. This makes it harder to send the wrong type.
| .query_row([], |row| row.get::<_, String>(0)); | ||
| assert!(res.is_err()); | ||
| assert_eq!(res, Err(rusqlite::Error::QueryReturnedNoRows)); | ||
|
|
There was a problem hiding this comment.
Can you also check that the db_version inserted and the ones Corrosion associated with its internal version are correct? Possibly by trying to apply the bad change first.
I vaguely recall we do some db version arithmetics and we might need to subtract when we're rolling back a savepoint.
jeromegn
approved these changes
Nov 28, 2024
This enables us to process other vesions in process_multiple_changes even if one of them fails
somtochiama
force-pushed
the
somto/fix-failed-changes
branch
from
bea5135 to
68daa16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the following changes:
process_multiple_changesso if one version fails we can continue with the others.