Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement tls on corro-pg #283

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

implement tls on corro-pg #283

wants to merge 7 commits into from

Conversation

lucas-jacques
Copy link

No description provided.

@lucas-jacques lucas-jacques marked this pull request as draft January 20, 2025 01:39
jeromegn
jeromegn reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@jeromegn jeromegn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! You could try a small refactor to prevent unwrapping the tls acceptor.

crates/corro-pg/src/lib.rs Outdated Show resolved Hide resolved
@lucas-jacques lucas-jacques marked this pull request as ready for review January 21, 2025 01:20
jeromegn
jeromegn reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@jeromegn jeromegn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I made a small comment to prevent an unwrap.

crates/corro-pg/src/lib.rs Outdated Show resolved Hide resolved
somtochiama
somtochiama reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@somtochiama somtochiama left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR @lucas-jacques.

This looks good! Just a couple of nitpics

crates/corro-pg/src/lib.rs Outdated Show resolved Hide resolved
crates/corro-pg/src/lib.rs Outdated Show resolved Hide resolved
@jeromegn
Copy link
Member

Hmm, sorry, I merged another branch that was more important and now yours has conflicts. Would you mind fixing them?

@lucas-jacques
Copy link
Author

@jeromegn No problem, it should be ok now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somtochiama somtochiama somtochiama left review comments

@jeromegn jeromegn jeromegn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucas-jacques @jeromegn @somtochiama