Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add and enable OpenAI strict mode #55

Merged
merged 11 commits into from
Dec 5, 2024
Merged

fix: add and enable OpenAI strict mode #55

merged 11 commits into from
Dec 5, 2024

Conversation

undo76
Copy link
Contributor

@undo76 undo76 commented Dec 4, 2024

Deal with OpenAI idiosyncrasies regarding JSON schemas.

@undo76 undo76 requested a review from lsorber December 4, 2024 16:35
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clarification questions.

src/raglite/_eval.py Show resolved Hide resolved
src/raglite/_eval.py Outdated Show resolved Hide resolved
src/raglite/_extract.py Outdated Show resolved Hide resolved
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identified one blocker, but after that this should be good to merge!

src/raglite/_eval.py Outdated Show resolved Hide resolved
src/raglite/_eval.py Outdated Show resolved Hide resolved
src/raglite/_eval.py Outdated Show resolved Hide resolved
src/raglite/_extract.py Outdated Show resolved Hide resolved
tests/test_extract.py Outdated Show resolved Hide resolved
@undo76 undo76 force-pushed the fix/ms-json-schema branch from 72dc6ae to 6e2d053 Compare December 5, 2024 13:23
@lsorber lsorber changed the title fix: OpenAI json_schema doesn't validate. fix: add and enable OpenAI strict mode Dec 5, 2024
@lsorber lsorber merged commit 9e48b20 into main Dec 5, 2024
2 checks passed
@lsorber lsorber deleted the fix/ms-json-schema branch December 5, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants