This repository has been archived by the owner on Sep 12, 2018. It is now read-only.
Make used NSBundle overridable
#121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to have been abandoned. But i agree with this. I use ObjectiveRecord within a private cocoa pod and the fetching of the ManagedObjectModel needs to be done within a bundle within a framework within the main bundle. The travis issue if i remember correctly has to do with Travis changing the ruby version on their OS X images. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
ObjectiveRecordas a dynamic framework,NSBundle.bundleForClass(self)returns the framework's bundle which then, in turn, won't yield the correct CoreData model file. By overriding the bundle when usingCoreDataManagerthis can be fixed.