Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed adjustPreset in player, to work around two pathological cases i… #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SAKryukov
Copy link

Fixed adjustPreset in player, to work around two pathological cases in instrument .js files (presets)::

  1. Some files have zones with zone.keyRangeLow > zone.keyRangeHigh; they are not used anyway and can be removed; this is a big performance improved, as, in some files, they reduce number of zones by order of magnitude
  2. All files have zones with 1-semiton gaps, such as 0..29, 29..36, and so on. This is methodically totally wrong, but works with integer number of semitones. Microtones can be fractional; if, for example, the pitch values is 29.1, the zone will never be found, and its fallback is a zone at index 0. It produces intolerably bad quality of sound.

The fix is in just one function, just few line; it does not change sounds with integer number of semitones:

this.adjustPreset = function (audioContext, preset) {
    const fixedZones = [];
    for (let zone of preset.zones) {
        if (zone.keyRangeLow > zone.keyRangeHigh) continue; // pathological case, not used anyway
        fixedZones.push(zone);
        this.adjustZone(audioContext, zone);
    } //loop preset.zones
    preset.zones = fixedZones;
    // removing 1-semitone gaps between zones; important for microtones:
    for (let index = 1; index < preset.zones.length; ++index)
        preset.zones[index].keyRangeLow = preset.zones[index - 1].keyRangeHigh;
};

It fully fixes issue 8 in non-obtrusive comprehensive way.

…n instrument .js files (presets):

1) some files have zones with zone.keyRangeLow > zone.keyRangeHigh; they are not used anyway and can be removed; this is a big performance improved, as, in some files, they reduce number of zones by order of magnitude
2) ALL files have zones with 1-semiton gaps, such as 0..29, 29..36, and so on. This is methodically totally wrong, but works with integer number of semitones. Microtones can be fractional; if, for example, the pitch values is 29.1, the zone will never be found, and its fallback is a zone at index 0. It produces intolerably bad quality of sound.

The fix is in just one function, just few line; it does not change sounds with integer number of semitones:

this.adjustPreset = function (audioContext, preset) {
    const fixedZones = [];
    for (let zone of preset.zones) {
        if (zone.keyRangeLow > zone.keyRangeHigh) continue; // pathological case, not used anyway
        fixedZones.push(zone);
        this.adjustZone(audioContext, zone);
    } //loop preset.zones
    preset.zones = fixedZones;
    // removing 1-semitone gaps between zones; important for microtones:
    for (let index = 1; index < preset.zones.length; ++index)
        preset.zones[index].keyRangeLow = preset.zones[index - 1].keyRangeHigh;
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ill timber/volume in specific tone range
1 participant