Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning on promise reject #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bolzon
Copy link

@bolzon bolzon commented Oct 16, 2018

When promise gets an error it wasn't returning on reject.

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files           1        1           
  Lines          55       55           
  Branches       12       12           
=======================================
  Hits           51       51           
  Misses          4        4
Impacted Files Coverage Δ
src/storage.ts 92.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8623309...364f9a3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant