-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added auto pypi update action #50
base: main
Are you sure you want to change the base?
Conversation
Updated this PR to use a token instead of the username and password. For this to work a Pypi API token secret called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my own clarification because I haven't setup anything like this before, is the goal to automatically update the pip package every time a PR is merged to main
?
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: '3.x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you gotten this to work with Python 3? Last we tried, we couldn't get VisIt to work with Python 3. I don't currently test on Python 3 as a result. So we probably want to get that working first before this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, I've just been using the remove graveyard tool with python 3. Good point I should have looked around a bit more before making this PR
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python | ||
uses: actions/setup-python@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this specifying something about using Python 2 whereas below it specifies python 3? (I am not familiar with pypi updates at all)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The v2 here is not referring to python2 but the version 2 of actions/checkout and version 2 of actions/setup-python
Yep that is exactly the goal of the PR. |
In view of the feedback, I have moved this to a draft PR. Perhaps we can come back to this once the whole package is working with python 3 Thanks for taking a look @kkiesling |
Please follow these guidelines when making a Pull Request.
This template was adapted from here and here.
Description
This github action automates the updating of the pypi distribution
Motivation and Context
Saves having to manually update the distribution each time and therefore saves developer time
Changes
automation feature
Behavior
behavior of code is unchanged just the distribution
Other Information
this will need a few secrets adding to the github repo for an account that has access to the pypi distribution
secrets.PYPI_USERNAME
secrets.PYPI_PASSWORD