Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Putting install scripts into dockerfile #822
Putting install scripts into dockerfile #822
Changes from 15 commits
24c6467
c2dba7a
5255950
2f558e4
11b4be9
14a9291
ad88096
8c8d579
21af7e7
5571c7a
5cdad9a
e331db4
8507e48
75d2419
3881de6
85884d6
d4723f8
7c93d5d
421e7ad
48a97a0
f77d721
dc2945c
de0f876
0b20fb3
10162c5
da899cc
5a84ef1
f5c70dd
488bf87
e071b9f
5340950
1b438e8
b0dbb59
28a5cbf
ebeaf59
6b89dd2
48ae87a
0ff7d85
ebc35e0
a30b95d
a872a23
92db99c
47afa61
97e1438
2669098
b25e3c8
ad9c95c
59e843a
33f0e07
051ec10
8e4da44
5ddc8f8
4a123b5
eb91b60
d3edab8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed - done in #103
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I am not quite sure which part of this embree clone/install was done in #103
I have removed the 2nd
mkdir build
if that is what was neededThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done in line 130 isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raising this one again...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we needed to declare
ENV
in each build stage they are used as they were not carried between build stages.