Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eigen3 #941

Closed
wants to merge 4 commits into from
Closed

Remove eigen3 #941

wants to merge 4 commits into from

Conversation

ahnaf-tahmid-chowdhury
Copy link
Member

This PR removes Eigen3 from DAGMC dependency.

@ahnaf-tahmid-chowdhury
Copy link
Member Author

What!!! I have turned off BLASLAPACK, but it seems the CMake is still considering it enabled!

@ahnaf-tahmid-chowdhury
Copy link
Member Author

I see, we need to enable blaslapack and need to find lapack, which will enable Fortran support. In that way we can ignore Eigen3 support for MOAB 😕. @gonuke, do you like to proceed with blaslapack?

More info: here

@gonuke
Copy link
Member

gonuke commented Feb 15, 2024

We definitely want Eigen3 and not BLAS and LAPACK.

@gonuke
Copy link
Member

gonuke commented Feb 15, 2024

I'm not sure what problem this is trying to solve?

@ahnaf-tahmid-chowdhury
Copy link
Member Author

This one #799

@gonuke
Copy link
Member

gonuke commented Feb 15, 2024

This one #799

I thought that might be it. This is a different problem. The problem is not that Eigen3 is a dependency of DAGMC. The problem is that Eigen3 is included in header files of MOAB and DAGMC that are required by downstream apps, even when it may not be necessary. The solution to this requires a little more careful analysis of each header file that included Eigen3 headers, moving the Eigen3 include to the source file, and seeing whether some forward declarations are necessary where the Eigen3 has been removed from headers.

@ahnaf-tahmid-chowdhury
Copy link
Member Author

Thank you for highlighting the issue with Eigen3 inclusion in header files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove need for downstream codes to have Eigen3 installed
2 participants