Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve missing library when building dockerfile #114

Merged
merged 3 commits into from
Jun 24, 2024
Merged

resolve missing library when building dockerfile #114

merged 3 commits into from
Jun 24, 2024

Conversation

Edgar-21
Copy link
Contributor

@Edgar-21 Edgar-21 commented Jun 21, 2024 •
edited
Loading

The Build & publish Docker image for ParaStell CI action currently is failing since apt-get cannot find libtiff5. I noticed the base image had updated just prior to this failure, and tried with tag for the previous docker image which resolved the missing library issue.

Fixes #115

@Edgar-21 Edgar-21 marked this pull request as ready for review June 21, 2024 13:49
gonuke
gonuke requested changes Jun 23, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you saw more in the description about which library was missing and/or refer to an issue that documents this? It's useful to know what problem a PR is actually solving.

Dockerfile Outdated Show resolved Hide resolved
@Edgar-21 Edgar-21 changed the title add specific tag to base image, should fix missing library issue add specific tag to base image Jun 24, 2024
@Edgar-21
Copy link
Contributor Author

My apologies, I edited the description to provide some more detail. This was mentioned briefly in the parastell channel a few weeks back as well, just took me a while to get around to submitting this PR.

@gonuke
Copy link
Member

gonuke commented Jun 24, 2024

It looks like libtiff5-dev is available - can we try switching to that and unpinning the miniconda image version? Pinning specific versions usually ends up leading to trouble down the road...

@Edgar-21 Edgar-21 changed the title add specific tag to base image resolve missing library when building dockerfile Jun 24, 2024
@gonuke gonuke merged commit 002adc2 into main Jun 24, 2024
2 checks passed
@connoramoreno connoramoreno deleted the fix_dockerfile branch July 8, 2024 18:21
connoramoreno pushed a commit that referenced this pull request Sep 10, 2024
@gonuke
Merge pull request #114 from svalinn/fix_dockerfile
dff6f4a 
resolve missing library when building dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build & publish Docker image for ParaStell CI fails, unable to find libtiff5
2 participants
@Edgar-21 @gonuke