Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul radial distance utility #158

Merged
merged 25 commits into from
Oct 9, 2024
Merged

Overhaul radial distance utility #158

merged 25 commits into from
Oct 9, 2024

Conversation

connoramoreno
Copy link
Collaborator

@connoramoreno connoramoreno commented Sep 19, 2024

Overhauls the radial distance utility. Changes include:

  • Leveraging recent updates to the magnet workflow
  • Code restructuring
  • General code improvements
  • Addition of a function to handle all radial distance utility functionality, removing the need to call several functions when using the utility
  • Addition of a function to enforce helical symmetry in a matrix whose rows and columns correspond to regularly spaced angular arrays
  • Addition of a function to smooth a matrix using Gaussian filtering without increasing the value of matrix elements

@connoramoreno
Copy link
Collaborator Author

I'm beginning to wonder if it might be worth converting this script to an object-oriented version

parastell/radial_distance_utils.py Outdated Show resolved Hide resolved
parastell/radial_distance_utils.py Outdated Show resolved Hide resolved
parastell/radial_distance_utils.py Outdated Show resolved Hide resolved
parastell/radial_distance_utils.py Outdated Show resolved Hide resolved
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really impressed by the application of best practices here @connoramoreno - nice cleanup! I have a few more comments to continue the journey...

parastell/utils.py Outdated Show resolved Hide resolved
parastell/utils.py Outdated Show resolved Hide resolved
parastell/utils.py Outdated Show resolved Hide resolved
parastell/utils.py Outdated Show resolved Hide resolved
parastell/utils.py Show resolved Hide resolved
parastell/magnet_coils.py Outdated Show resolved Hide resolved
parastell/magnet_coils.py Outdated Show resolved Hide resolved
Examples/radial_distance_example.py Outdated Show resolved Hide resolved
Examples/radial_distance_example.py Outdated Show resolved Hide resolved
Examples/radial_distance_example.py Outdated Show resolved Hide resolved
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little final polish...

parastell/magnet_coils.py Show resolved Hide resolved
parastell/utils.py Outdated Show resolved Hide resolved
parastell/utils.py Outdated Show resolved Hide resolved
parastell/utils.py Outdated Show resolved Hide resolved
parastell/utils.py Outdated Show resolved Hide resolved
parastell/utils.py Outdated Show resolved Hide resolved
parastell/utils.py Outdated Show resolved Hide resolved
parastell/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment for posterity

parastell/utils.py Show resolved Hide resolved
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates @connoramoreno

@gonuke gonuke merged commit ba23085 into main Oct 9, 2024
3 checks passed
@connoramoreno connoramoreno deleted the rdu-modifications branch October 9, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants