-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pymoab as a Dependency #24
Remove pymoab as a Dependency #24
Conversation
|
||
try: | ||
from pymoab import core, types, rng, tag | ||
except ImportError as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I suggested this in #1, but the message is a overly verbose for my taste. There are (somewhat dated) instructions on how to build MOAB with PyMOAB enabled here. I think we should point to them in this message and update the installation instructions there.
Also, while we may want to add a logging capability to this project in the future, I don't see the point of importing that module for this single message. We can raise our own message from a ModuleNotFoundError
try:
from pymoab import core, types, rng, tag
except ImportError as e:
msg = 'PyMOAB package was not found, please install this package using the instructions found here: https://ftp.mcs.anl.gov/pub/fathom/moab-docs/building.html'
raise ModuleNotFoundError(msg) from e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments form me, but I think this is close!
Co-authored-by: Patrick Shriwise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'll let @pshriwise decide if it's ready
Description
This PR removes
pymoab
frompyproject.toml
as a dependency.Changes
Here are the main changes made in this PR:
pyproject.toml
: Removedpymoab
from the list of dependencies.dagnav.py
: Added instructions to handle the case ifpymoab
is not found.