Non persistent connections #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeMonk
approved these changes
Jan 3, 2019
| @@ -110,6 +110,7 @@ class TestConfig: | |||
| interactive = False | |||
| verbose = False | |||
| ssl_insecure = False | |||
| non_persistent = False # Disables keep-alive pycurl option | |||
There was a problem hiding this comment.
Would be nice to specify testing -vs- benchmarking here. Not sure how hard that would be though.
CodeMonk
approved these changes
Jan 7, 2019
|
Actually, the latest version of pycurl already takes care of handle reuse on its own by resetting instead of closing, the explicit handle reuse in the framework is no longer necessary and, in my personal opinion, confusing - simple is better than complex, right? -, now, in regards to tcp persistent connections I rather this to be optional to avoid issues in very complicated use cases - don't want to ruin it for anyone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to disable persistent connections in order to avoid issues with Django