Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licenses page (Close #566) #586

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

MacFJA
Copy link
Collaborator

@MacFJA MacFJA commented Feb 10, 2024

🎯 Changes

  • Add the missing licenses page
  • Fix page about link for licenses to be an internal url
  • Add NPM script to regenerate the licenses list

✅ Checklist

  • I have given my PR a descriptive title
  • I have run pnpm run lint locally on my changes

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sveltesociety-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2024 0:31am
sveltesociety-dev-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2024 0:31am

@MacFJA
Copy link
Collaborator Author

MacFJA commented Feb 10, 2024

Vercel fail to deploy the preview, but I have no idea why.
@lachlancollins Do you know the reason ? (I have no access to the Vercel logs)

@lachlancollins
Copy link
Collaborator

lachlancollins commented Feb 11, 2024

Vercel fail to deploy the preview, but I have no idea why. @lachlancollins Do you know the reason ? (I have no access to the Vercel logs)

@MacFJA I can't see either, but I'm wondering if it's not running postinstall? That would cause the build to fail.

EDIT: Actually it shouldn't since licenses.json is committed to the repo... I'm not too sure!

@MacFJA
Copy link
Collaborator Author

MacFJA commented Feb 11, 2024

@MacFJA I can't see either, but I'm wondering if it's not running postinstall? That would cause the build to fail.

It was indeed the postinstall script.

I changed it to a more "conventional" script, but now it has to be explicitly executed

@kevmodrome kevmodrome merged commit b11f064 into svelte-society:main Apr 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link at /about
3 participants