Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrates to eslint 9 & flat config #968

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

sverweij
Copy link
Owner

Description

  • bumps linting setup to eslint 9
  • migrates (both) eslint configurations to 'flat config'
  • The complexity calculation changed, so I've set the max allowed complexity a little bit higher (to 10; eslint's default is 20 (!) - previously we used 6).

Our eslint-config-moving-meadow configuration is still non-flat, so @eslint/migrate-config wrapped it in a compat call, which is fine for now.

Motivation and Context

eslint 8 is EOL and won't be supported any longer. An alternative till eslint 10 is setting the ESLINT_USE_FLAT_CONFIG environment variable to false, but that still made eslint emit a warning message on each run + we had to do the work anyway, eventually.

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Nov 24, 2024

Code Climate has analyzed commit b8009f0 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij changed the title chore: moves eslint to flat config, migrates to eslint 9 chore: migrates to eslint 9 & flat config Nov 24, 2024
@sverweij sverweij merged commit 8a288dd into main Nov 24, 2024
8 checks passed
@sverweij sverweij deleted the chore/migrate-to-eslint-9-flat-configs branch November 24, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant