Fix <CompilerGeneratedFilesOutputPath> in Svg.Custom.

[H1Gdev]

Reference Issue

Ref. #1141

What does this implement/fix? Explain your changes.

Because value of <CompilerGeneratedFilesOutputPath> is invalid, Generated directory is generated at root of execution environment.(ex: c:\Generated)

This PR will generate Generated under this project.

Any other comments?

[mrbean-bremen]

Thanks - please add release notes. @paulushub - please have a look!

[paulushub]

Thanks - please add release notes. @paulushub - please have a look!

Please, really sorry I am out - I always have something to occupy my time. But @inforithmics is in.
On the PR, take a look - I could not see any difference.
Sounds like simply replacing SvgSourcesBasePath with SvgRootPath to me.

[mrbean-bremen]

Please, really sorry I am out - I always have something to occupy my time.

That is sad of course (that you are out of course, not that you have something to occupy you - if I don't have something left to occupy me, I'm probably dead 😀 ).
I added you as reviewer only because the original commit was yours, as a sanity check.

I'll wait for the release notes and merge in this case.

[H1Gdev]

@mrbean-bremen

please add release notes.

Because it was a simple PR #1141, I thought it was not necessary.
Please check it because it has been added.

Sounds like simply replacing SvgSourcesBasePath with SvgRootPath to me.

We can understand by building...
I think it is annoying to other developers because it is generated in a place that is not temporary directory.

[paulushub]

I think it is annoying to other developers because it is generated in a place that is not temporary directory.

What you documented is CompilerGeneratedFilesOutputPath, that should be a line fix.
What is the need in changing property name without documenting why? Such will only waste reviewer's time.
It took time to clear the PRs, hope you guys will make it work this time - good luck.

[mrbean-bremen]

Because it was a simple PR #1141, I thought it was not necessary.

Only because the change was after the latest release, otherwise I would have agreed.

And while I approved this (too fast), the release notes are actually not saying what has changed in comparison with the latest release (e.g. the location of Generated), so I would ask you to change this.

[mrbean-bremen]

Thanks!