Add some Python client tests #1441
Conversation
anlambert
force-pushed
the
python-client-tests
branch
from
2c7ea32
to
090cfe1
Compare
There was a problem hiding this comment.
Hey, thanks for the PR!
We'd be glad to have more unit tests, so please do add anything that you feel makes sense. Doesn't all have to be one PR either, but of course I'll honor your preference w.r.t. PR setup and will wait for the draft state to be removed before merging.
Also, I just noticed when reviewing the workflow file that there's some weird thing in there that you seem to have copied from our existing python lint workflows. Would you mind applying the changes from #1445 to the new workflow file? Specifically, I'm talking about the workflow trigger rules, and the version of the setup-python action.
Great, I do not intend to cover all the Python OpenAPI code but adding a couple of simple tests on the most used features (notably sending messages) should be sufficient to avoid bad surprises in the future. I will try to finish that work y the end of the week.
Sure. |
anlambert
force-pushed
the
python-client-tests
branch
3 times, most recently
from
3f174ad
to
5075885
Compare
|
I see you force-pushed a few times, is this still work in progress? |
Sorry, I got delayed on this but I think it is ready for review. This PR does not cover the whole Svix Python OpenAPI client features but I think it should be enough to catch any important breakages that could be introduced. I am going to rebase it to the main branch and mark it ready for review. |
anlambert
force-pushed
the
python-client-tests
branch
from
5075885
to
403fea3
Compare
Done ! |
This PR adds some unit tests for the Svix Python OpenAPI client to avoid breaking things (see #1440).
This is still a work in progress, I just added a couple of simple tests but one of them showcases the issue mentioned above (see Github Actions job report for newly added workflow).