Revert changes to Python code generation #1442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasn
reviewed
Sep 17, 2024
| @@ -1074,7 +1074,7 @@ async def create( | |||
| with_content=False, | |||
| **options.to_dict(), | |||
| ) | |||
| ret.payload = MessageOutPayload.from_dict(message_in.payload.to_dict()) | |||
| ret.payload = message_in.payload | |||
There was a problem hiding this comment.
Suggested change
| ret.payload = message_in.payload | |
| ret.payload = t.Cast(message_in.payload, t.Any) |
Something like this?
tasn
reviewed
Sep 17, 2024
| @@ -1,5 +1,5 @@ | |||
| {% set class_name = model.class_info.name %} | |||
| {% if model.required_properties == [] and model.optional_properties == [] and False %} | |||
| {% if model.required_properties == [] and model.optional_properties == [] %} | |||
There was a problem hiding this comment.
The revert looks correct, the and False looks silly and that it'll break stuff, so no wonder if broke stuff.
|
Superseded by #1443. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Python library had a pretty significant breaking change. See #1440.
Solution
Revert the Python codegen changes from #1423.