Make sentry not report exceptions from the HTTP client (#525)

svthalia · Nov 20, 2024 · 99365b6 · 99365b6
1 parent af5b4f9
commit 99365b6
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 11 deletions.
diff --git a/lib/api/concrexit_api_repository.dart b/lib/api/concrexit_api_repository.dart
@@ -37,7 +37,15 @@ class LoggingClient extends oauth2.Client {
 
   @override
   Future<StreamedResponse> send(BaseRequest request) async {
-    final response = await super.send(request);
+    StreamedResponse response;
+    try {
+      response = await super.send(request);
+    } catch (e) {
+      if (kDebugMode) {
+        print('url: ${request.url}, failed: $e');
+      }
+      rethrow;
+    }
     if (kDebugMode) {
       print('url: ${request.url}, response code: ${response.statusCode}');
     }

diff --git a/lib/blocs/auth_cubit.dart b/lib/blocs/auth_cubit.dart
@@ -145,10 +145,13 @@ class AuthCubit extends Cubit<AuthState> {
                   ),
                 );
               },
-              httpClient: SentryHttpClient(failedRequestStatusCodes: [
-                SentryStatusCode(400),
-                SentryStatusCode.range(405, 499),
-              ]),
+              httpClient: SentryHttpClient(
+                failedRequestStatusCodes: [
+                  SentryStatusCode(400),
+                  SentryStatusCode.range(405, 499),
+                ],
+                captureFailedRequests: false,
+              ),
             ),
             config: apiConfig,
             onLogOut: logOut,

diff --git a/lib/blocs/list_cubit.dart b/lib/blocs/list_cubit.dart
@@ -100,11 +100,11 @@ abstract class ListCubit<F, T, S> extends Cubit<S> {
     List<Future<List<T>>> futuresUp = [];
     List<Future<List<T>>> futuresDown = [];
     for (final source in sources) {
+      source._nextOffsetUp = 0;
+      source._nextOffsetDown = 0;
+      source.isDoneUp = false;
+      source.isDoneDown = false;
       try {
-        source._nextOffsetUp = 0;
-        source._nextOffsetDown = 0;
-        source.isDoneUp = false;
-        source.isDoneDown = false;
         futuresUp.add(source.moreUp());
         futuresDown.add(source.moreDown());
       } on ApiException catch (exception) {
@@ -115,8 +115,13 @@ abstract class ListCubit<F, T, S> extends Cubit<S> {
     cleanupOldState();
     List<List<T>> resultsUp = [];
     List<List<T>> resultsDown = [];
-    resultsUp = await Future.wait(futuresUp);
-    resultsDown = await Future.wait(futuresDown);
+    try {
+      resultsUp = await Future.wait(futuresUp);
+      resultsDown = await Future.wait(futuresDown);
+    } on ApiException catch (exception) {
+      safeEmit(failure(exception.message));
+      return;
+    }
 
     // Discard result if _searchQuery has
     // changed since the request was made.