Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons update #265

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Conversation

PYROTEKNIK
Copy link
Collaborator

@PYROTEKNIK PYROTEKNIK commented Jun 23, 2021

-buttons no longer post messages to global chat unless a player received points or it's relevant to other players. Any outcomes that are publicly announced are attributed to "the hilarious one"
-Improved placement variety. Will attempt to shift so they don't hang over surface edges or halfway inside surfaces
-Improved collision so that buttons can't be unpressable if they're visible.
-More things can happen
-Changed materials, easier to see from afar
-You can press them using damage or by touching them.

Copy link
Collaborator Author

@PYROTEKNIK PYROTEKNIK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this spraypaint cl_init change is supposed to be here. how do i know it's not gonna break the more recent version on the server? is there a way to remove it? the one in the commit called "fuck"

@swampservers
Copy link
Owner

probably git checkout upstream/master -- lua/weapons/weapon_spraypaint/cl_init.lua

@PYROTEKNIK
Copy link
Collaborator Author

alright, i'll take a look at this after i'm finished with the pointshop stuff.

@swampservers
Copy link
Owner

@PYROTEKNIK do you wanna merge this?

@PYROTEKNIK
Copy link
Collaborator Author

i have one more change in mind before it's ready. i'll try to get that soon

…Value into account. basically just the default hook but edited.
-Tweaked point prize value

-The "nothing" effect will play a random soundscript with the speaker effect on it.

-Removed rare effect which gauntlet snaps half the server, and replaced it with one that gives the player a gauntlet with 50 ammo.

-tweaked bountyall to sometimes affect only kleiners, or both players and kleiners. kleiners get teleported around if it's just them and they get an increase in kill value.

-rare chance to give prop or gun loot box
-rare chance to set model to a temporary model
-rare chance to teleport every kleiner bot to you
-rare chance to get increased health
-chance to put player into fast or slow motion
health bar will stay visible if health goes above default value
increased vertical variation because it really liked placing them very high up
removed annoying soundspam
funny extra decal spray set
spawnobject can spawn manhacks
event that spawns a bfg projectile
neck twist has a chance to fully invert your camera, timer should gradually return you to normal
i don't think the projectile uses this
glualint, documented each outcome
@PYROTEKNIK
Copy link
Collaborator Author

@swampservers i think this is ready. i ended up adding some more significant changes.
let me know if there's anything i can do to make reviewing this easier. Sorry if this is a lot of changes

error fix, changed text
@PYROTEKNIK
Copy link
Collaborator Author

Whenever you feel ready to, I need some input other than "stop adding to this". There's nothing useful I can do with just that in hindsight. If the issue is that you don't feel this is worth putting money into, feel free to not pay me for updating this. I just want it to be a good feature. I even made a bunch of changes you suggested because I agree this should not be some major activity on the server. The point of buttons is to create infrequent, less predictable events, and i think that kind of stuff can be stimulating for the server. The goal behind adding more things for it to do is to reduce the chances of the strictly good/bad outcomes.

@swampservers
Copy link
Owner

Whenever you feel ready to, I need some input other than "stop adding to this". There's nothing useful I can do with just that in hindsight. If the issue is that you don't feel this is worth putting money into, feel free to not pay me for updating this. I just want it to be a good feature. I even made a bunch of changes you suggested because I agree this should not be some major activity on the server. The point of buttons is to create infrequent, less predictable events, and i think that kind of stuff can be stimulating for the server. The goal behind adding more things for it to do is to reduce the chances of the strictly good/bad outcomes.

I didn't tell you that in hindsight, I have said it several times to you over the past months. This random button feature does not need more outcomes. The gamemode is not hide and seek.

If you want to be helpful, work on the widget/gadget thing for editing customizer props.

…MovementValue into account. basically just the default hook but edited."

This reverts commit 545dc02.
@PYROTEKNIK
Copy link
Collaborator Author

PYROTEKNIK commented Jul 25, 2021

I intend to resume work on the customizer thing, but it's really bothering me to continue leaving projects unfinished.
I really do feel like it needed a few more than it had. I think it's kind of pointless to have it if it's only doing like 7 different things and 4 of them are effectively free points. i figured i might as well add a bunch now so i can focus on other stuff afterward

ENT.Category = "PYROTEKNIK"
ENT.Spawnable = true
ENT.AdminSpawnable = true
HIDDENBUTTON_TRANSMIT_DISTANCE = 3000
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is so high it makes the implementation basically pointless


local recip = RecipientFilter()
recip:AddPVS(button:GetPos())
recip:AddPVS(button:GetPos() + button:GetUp()*3)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick one

return recip
end

-- if the player is still finding them super consistently, even after being excluded from model transmission, force a shitty prize
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is that possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants