Merge pull request #81 from nobrayner/fix-80

Fix: Result.fromJSON return type

package.json

@@ -40,6 +40,7 @@
     "format": "prettier '**/*' -u -w",
     "prepack": "yarn test && yarn build",
     "test": "vitest run",
+    "test:typecheck": "tsc --noEmit -p tsconfig.test.json",
     "typecheck": "tsc --noEmit",
     "benchmark": "node benchmark/src/option && node benchmark/src/result && node benchmark/src/future && node benchmark/src/future-result"
   },

src/OptionResult.ts

@@ -421,7 +421,7 @@ class __Result<A, E> {
     return false;
   };
 
-  static fromJSON = <A, E>(value: JsonResult<A, E>) => {
+  static fromJSON = <A, E>(value: JsonResult<A, E>): Result<A, E> => {
     return value.tag === "Ok"
       ? Result.Ok(value.value)
       : Result.Error(value.error);

test/AsyncData.test.ts

@@ -380,3 +380,12 @@ test("AsyncData isAsyncData", async () => {
   expect(AsyncData.isAsyncData([])).toEqual(false);
   expect(AsyncData.isAsyncData({})).toEqual(false);
 });
+
+test("AsyncData JSON serialization", () => {
+  const data = AsyncData.Loading<number>();
+  expect(
+    AsyncData.fromJSON(data.toJSON()).tap(() => {
+      // use async data
+    }),
+  ).toEqual(data);
+});

test/Future.test.ts

@@ -464,7 +464,7 @@ test("Future concurrent", async () => {
           --parallel;
         }),
       () =>
-        Future.make<4>((resolve) => {
+        Future.make((resolve) => {
           expect(++parallel).toBeLessThanOrEqual(2);
           setTimeout(() => resolve(undefined), 75);
         })

test/Option.test.ts

@@ -202,3 +202,12 @@ test("Option.isOption", async () => {
   expect(Option.isOption([])).toEqual(false);
   expect(Option.isOption({})).toEqual(false);
 });
+
+test("Option JSON serialization", () => {
+  const option = Option.None();
+  expect(
+    Option.fromJSON(option.toJSON()).tap(() => {
+      // Use option
+    }),
+  ).toEqual(option);
+});

test/Result.test.ts

@@ -253,3 +253,19 @@ test("Result.isResult", async () => {
   expect(Result.isResult([])).toEqual(false);
   expect(Result.isResult({})).toEqual(false);
 });
+
+test("Result JSON serialization", async () => {
+  const resultOk = Result.Ok({ thing: "hello" });
+  expect(
+    Result.fromJSON(resultOk.toJSON()).tap(() => {
+      // Use result
+    }),
+  ).toEqual(resultOk);
+
+  const resultError = Result.Error(new Error("Oops"));
+  expect(
+    Result.fromJSON(resultError.toJSON()).tap(() => {
+      // Use result
+    }),
+  ).toEqual(resultError);
+});

tsconfig.test.json

@@ -0,0 +1,9 @@
+{
+  "extends": "./tsconfig.json",
+  "include": ["**/*.test.ts"],
+  "exclude": ["node_modules", "dist"],
+  "compilerOptions": {
+    "noEmit": true,
+    "skipLibCheck": true
+  },
+}