Remove cast

swan-io · Aug 7, 2023 · 6aebbe2 · 6aebbe2
1 parent a046974
commit 6aebbe2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/AsyncData.ts b/src/AsyncData.ts
@@ -417,8 +417,9 @@ export const AsyncData = {
   },
 
   isAsyncData: (value: unknown): value is AsyncData<unknown> =>
-    Object.prototype.isPrototypeOf.call(doneProto, value as Object) ||
-    Object.prototype.isPrototypeOf.call(asyncDataProto, value as Object),
+    value != null &&
+    (Object.prototype.isPrototypeOf.call(doneProto, value) ||
+      Object.prototype.isPrototypeOf.call(asyncDataProto, value)),
 
   P: asyncDataPattern,
   pattern: asyncDataPattern,

diff --git a/src/Future.ts b/src/Future.ts
@@ -31,7 +31,7 @@ export class Future<A> {
   };
 
   static isFuture = (value: unknown): value is Future<unknown> =>
-    Object.prototype.isPrototypeOf.call(futureProto, value as Object);
+    value != null && Object.prototype.isPrototypeOf.call(futureProto, value);
 
   /**
    * Creates a future resolved to the passed value

diff --git a/src/OptionResult.ts b/src/OptionResult.ts
@@ -172,8 +172,9 @@ export const Option = {
   None,
 
   isOption: (value: unknown): value is Option<unknown> =>
-    Object.prototype.isPrototypeOf.call(optionProto, value as Object) ||
-    Object.prototype.isPrototypeOf.call(someProto, value as Object),
+    value != null &&
+    (Object.prototype.isPrototypeOf.call(optionProto, value) ||
+      Object.prototype.isPrototypeOf.call(someProto, value)),
 
   /**
    * Create an Option from a nullable value
@@ -481,8 +482,9 @@ export const Result = {
   Error,
 
   isResult: (value: unknown): value is Result<unknown, unknown> =>
-    Object.prototype.isPrototypeOf.call(okProto, value as Object) ||
-    Object.prototype.isPrototypeOf.call(errorProto, value as Object),
+    value != null &&
+    (Object.prototype.isPrototypeOf.call(okProto, value) ||
+      Object.prototype.isPrototypeOf.call(errorProto, value)),
 
   /**
    * Runs the function and resolves a result of its return value, or to an error if thrown