13 Additional Colors #102
Closed
13 Additional Colors #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapagarwal
reviewed
Oct 6, 2019
geeksay.js
Outdated
| "red": "#ff0000", | ||
| "green": "#00ff00", | ||
| "purple": "#800080", | ||
| "fuchsia": "#ff00ff", |
There was a problem hiding this comment.
The translations are meant to be easily understood. Do you think you can read #ff00ff and decode it as fuchsia?
There was a problem hiding this comment.
Ah that's true! I'll take it out.
Some colors didn't translate well. Removed these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1 Added 13 additional color translations.