Refactored Geeksay.js and Added 2 Files: Quotes.js and Translations.js #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mport into main geeksay for more maintainable code
|
@swapagarwal I believe these adds will be helpful for future developers who want to add to the repo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 JS files, quotes.js and translations.js :
These files hold the quotes and translations. The code is easier to maintain and prevents the main document with the logic, geeksay.js, from becoming too long. This allows for easier iterations in the future.
The below screenshots shows the impact of the refactor, allowing the geeksay.js file to become more readable.
