Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigNumber: ts-ignore #3621

Merged
merged 50 commits into from
Nov 24, 2020
Merged

Conversation

Disti4ct
Copy link
Collaborator

@Disti4ct Disti4ct commented Nov 20, 2020

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming, keep simple
  • Tested desktop/mobile
  • Tested bright/dark
  • Tested en/ru
  • Affects money; I checked the functionality once again
  • I checked the PR once again

Original issue

#3562

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@iower iower self-requested a review November 23, 2020 12:09
@sorentobot
Copy link
Collaborator

Copy link
Collaborator

@iower iower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls remove all @is-ignore's from psbt.addOutput({ ... }), otherwise withdraw is broken

@sorentobot
Copy link
Collaborator

@noxonsu
Copy link
Member

noxonsu commented Nov 23, 2020

  • токены отправляет
  • токен max отправляет
  • биткоин отправляет
  • bitcoin max отправляет (кнопка max)
  • эфир отправляет
  • эфир max отправляет
  • отключить admin fee (закоментить конфиг) и проверить отправку btc
  • проверить свап btc/eth
  • admin fee btc показать отдельно
  • admin fee eth показать отдельно

@sorentobot
Copy link
Collaborator

@noxonsu noxonsu merged commit aff4a52 into swaponline:master Nov 24, 2020
@Disti4ct Disti4ct deleted the removeTsIgnoreBigNumber branch November 24, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants