Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #4157

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Cleanup #4157

merged 3 commits into from
Mar 29, 2021

Conversation

Disti4ct
Copy link
Collaborator

@Disti4ct Disti4ct commented Mar 28, 2021

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the PR once again

Original issue

#3511
#3562

Video / screenshot proof

SaveKeysModal before

before

SaveKeysModal after

after

@sorentobot
Copy link
Collaborator

@noxonsu noxonsu merged commit b0bf14e into swaponline:master Mar 29, 2021
@Disti4ct Disti4ct deleted the cleanup branch March 30, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants