Make move_to_container insert after the focused child of destination to match i3 behavior #8418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccdunder
force-pushed
the
move_to_container
branch
from
74d1a1f to
3e26353
Compare
ccdunder
commented
Nov 2, 2024
|
LGTM, thanks! |
|
Ah, please squash your commits into one. |
ccdunder
force-pushed
the
move_to_container
branch
from
8973c2e to
62e32d9
Compare
ccdunder
force-pushed
the
move_to_container
branch
2 times, most recently
from
33392b5 to
a76bbea
Compare
|
@Nefsen402, thanks for the LGTM! I squashed my commits. PTAL and approve when you have a sec. |
ccdunder
force-pushed
the
move_to_container
branch
from
a76bbea to
ef74d9b
Compare
ccdunder
force-pushed
the
move_to_container
branch
from
ef74d9b to
0e9d47e
Compare
Nefsen402
reviewed
Dec 11, 2024
Comment on lines
+274
to
+278
| } else { | ||
| // TODO: This branch is unreachable until workspaces can be marked. | ||
| // Issue url: https://github.com/swaywm/sway/issues/8474 | ||
| workspace_insert_tiling(target->pending.workspace, container, index); | ||
| } |
There was a problem hiding this comment.
I don't think it makes sense to include a branch for a feature that doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6818
See this comment for an example scenario.
See this code in i3 for reference.