scene: fix place above/below if sibling == node

Currently these functions remove the node from the scene if the sibling argument is the same node as the node. Making this case a noop is much more predictable behavior.
swaywm · Oct 12, 2021 · fba262b · fba262b
1 parent dc22a06
commit fba262b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/types/scene/wlr_scene.c b/types/scene/wlr_scene.c
@@ -442,7 +442,7 @@ void wlr_scene_node_place_above(struct wlr_scene_node *node,
 		struct wlr_scene_node *sibling) {
 	assert(node->parent == sibling->parent);
 
-	if (node->state.link.prev == &sibling->state.link) {
+	if (node == sibling || node->state.link.prev == &sibling->state.link) {
 		return;
 	}
 
@@ -457,7 +457,7 @@ void wlr_scene_node_place_below(struct wlr_scene_node *node,
 		struct wlr_scene_node *sibling) {
 	assert(node->parent == sibling->parent);
 
-	if (node->state.link.next == &sibling->state.link) {
+	if (node == sibling || node->state.link.next == &sibling->state.link) {
 		return;
 	}